linux-kernel - Re: [PATCH v3 2/2] spi: cadence: add support for Cadence XSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Sep 2021 12:24:03 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Parshuram Raju Thombare <pthombar@...ence.com>
Cc:     "lukas@...ner.de" <lukas@...ner.de>,
        "p.yadav@...com" <p.yadav@...com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jayshri Dajiram Pawar <jpawar@...ence.com>,
        Milind Parab <mparab@...ence.com>,
        Konrad Kociolek <konrad@...ence.com>
Subject: Re: [PATCH v3 2/2] spi: cadence: add support for Cadence XSPI
 controller

On Fri, Sep 03, 2021 at 10:47:50AM +0000, Parshuram Raju Thombare wrote:

> Oh, ok.  That is done at power on reset by the controller in 2 ways.
> 1. Using device discovery module, controller try to auto detect the valid protocol
>     mode by trying to read SFDP signature in various modes.
> 2. Particular protocol mode can be selected using bootstrap signals.

> I think mode_bits need to include protocol mode which is auto detected or
> set using bootstrap signals. I will make that change in next version. 

Yes, that sounds better.  I guess at least in the case of autodetection
the mode can be overridden by software later, but that can always be
added later if someone actually needs the feature.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)