linux-kernel - Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f572aca2-167a-be26-d89a-810c7023092f@linaro.org>
Date:   Fri, 3 Sep 2021 13:37:59 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Joakim Zhang <qiangqing.zhang@....com>,
        Rob Herring <robh@...nel.org>
Cc:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data" property

Hi Joakim,

On 18/08/2021 08:54, Joakim Zhang wrote:
> 
>> -----Original Message-----
>> From: Rob Herring <robh@...nel.org>
>> Sent: 2021年8月18日 3:58
>> To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> Cc: Joakim Zhang <qiangqing.zhang@....com>; shawnguo@...nel.org;
>> kernel@...gutronix.de; dl-linux-imx <linux-imx@....com>;
>> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
>> Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
>> property
>>
>> On Wed, Aug 11, 2021 at 11:16:49AM +0100, Srinivas Kandagatla wrote:
>>>
>>>
>>> On 10/08/2021 08:35, Joakim Zhang wrote:
>>>> Introduce "reverse-data" property for nvmem provider to reverse buffer.
>>>>
>>>> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
>>>> ---
>>>>    Documentation/devicetree/bindings/nvmem/nvmem.yaml | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
>>>> b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
>>>> index b8dc3d2b6e92..bc745083fc64 100644
>>>> --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
>>>> +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
>>>> @@ -61,6 +61,11 @@ patternProperties:
>>>>                  description:
>>>>                    Size in bit within the address range specified by reg.
>>>> +      reverse-data:
>>>> +        $ref: /schemas/types.yaml#/definitions/flag
>>>> +        description:
>>>> +          Reverse the data that read from the storage device.
>>>> +
>>>
>>> This new property is only going to solve one of the reverse order
>>> issue here.
>>> If I remember correctly we have mac-address stored in various formats ex:
>>> from old thread I can see
>>>
>>> Type 1: Octets in ASCII without delimiters. (Swapped/non-Swapped) Type
>>> 2: Octets in ASCII with delimiters like (":", ",", ".", "-"... so on)
>>> (Swapped/non-Swapped)
>>> Type 3: Is the one which stores mac address in Type1/2 but this has to
>>> be incremented to be used on other instances of eth.
>>> Type 4: Octets as bytes/u8, swapped/non-swapped
>>>
>>> I think its right time to consider adding compatibles to nvmem-cells
>>> to be able to specify encoding information and handle post processing.
>>
>> Yes. Trying to handle this with never ending new properties will end up with a
>> mess. At some point, you just need code to parse the data.
> 
> Thanks, Rob.
> 
> Hi Srinivas,
> 
Firstly Sorry for taking so long to reply as I was on vacation.

> Do you plan to implement it?

No, Am not planning to do this. But am happy to walk-thru the ideas that 
I have.

> 
> Or need me follow up? If yes, please input your insights to point me how to work for it.

Do we have some kind of meta data/information in nvmem memory to 
indicate the storage encoding?

Am I correct to say that this is only issue with mac-address nvmem cell?

Irrespective of where this encoding info comes from we have 2 options.

Option 1: Add callback to handle mac-address post-processing with in the 
provider driver.

Pros:
- It can deal with vendor specific non-standard encodings, and code is 
mostly with-in vendor specific nvmem provider driver and bindings.
- will keep nvmem core simple w.r.t handling data.

Cons:
- provider driver implement callback and new bindings.
- might need to add a nvmem-cell-type binding to be able differentiate 
the cell types and handle post-processing.

Option 2: nvmem core handles the post processing.

Pros:
- provider driver does not need to implement callbacks

Cons:
- We have to find a way to define vendor specific non-standard encoding 
information in generic bindings which is going to be a challenge and 
high chance of ending up in to much of clutter in generic bindings.

Finally, The way I look at this is that once we start adding 
post-processing in nvmem core then we might endup with code that will 
not be really used for most of the usecases and might endup with cases 
that might not be possible to handle in the core.


Does Option 1 work for you?

--srini

> 
> Thanks.
> 
> Best Regards,
> Joakim Zhang
>> Rob