linux-kernel - Re: [PATCH] tracing: Dynamically allocate the per-elt hist_elt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7bd15d7144dc87e473c7cc0a7f825f27527d15c.camel@gmail.com>
Date:   Fri, 03 Sep 2021 16:52:29 +0300
From:   Artem Bityutskiy <dedekind1@...il.com>
To:     Tom Zanussi <zanussi@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Dynamically allocate the per-elt hist_elt_data
 array

On Thu, 2021-09-02 at 15:57 -0500, Tom Zanussi wrote:
> Setting the hist_elt_data.field_var_str[] array unconditionally to a
> size of SYNTH_FIELD_MAX elements wastes space unnecessarily.  The
> actual number of elements needed can be calculated at run-time
> instead.
> 
> In most cases, this will save a lot of space since it's a per-elt
> array which isn't normally close to being full.  It also allows us to
> increase SYNTH_FIELD_MAX without worrying about even more wastage when
> we do that.
> 
> Signed-off-by: Tom Zanussi <zanussi@...nel.org>

Many thanks Tom! I've tested this one.

Tested-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>