linux-kernel - Re: [GIT PULL] first round of SCSI updates for the 5.14+ merge window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YTGkLhfYWcvj4YRn@infradead.org>
Date:   Fri, 3 Sep 2021 05:27:26 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     James Bottomley <James.Bottomley@...senpartnership.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Jens Axboe <axboe@...nel.dk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>
Subject: Re: [GIT PULL] first round of SCSI updates for the 5.14+ merge window

On Thu, Sep 02, 2021 at 04:23:43PM -0700, James Bottomley wrote:
> > 
> > Just checking that was fine, and I notice how *many* places do that.
> > 
> > Should the blk_execute_rq() function even take that "struct gendisk
> > *bd_disk" argument at all?

No, it shouldn't.  rq->rq_disk should go away and use rq->q->disk
instead.  This has been on my TODO list, but didn't make the cut for
this merge window.