linux-kernel - Re: [PATCH] regulator: core: resolve supply voltage deferral silently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Sep 2021 10:09:04 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Chen-Yu Tsai <wenst@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: core: resolve supply voltage deferral silently

On Fri, Sep 3, 2021 at 4:11 AM Mark Brown <broonie@...nel.org> wrote:
> In terms of not understanding the issue here is that the patch didn't
> pass the smell test, it was your explanation that helped here not the
> pointing at a driver change that lacks obvious relevance.  I really
> don't know what the reader is supposed to infer about the change from
> the commit,

OK, I might see where you're coming from. Personally, I'd still like
to reference the commit in some way, because I've never used bypass
mode that I'm aware of, but the mentioned commit added a new case that
I do care about. I like documenting motivation, where reasonable --
but apparently I need to do a better job of that part.

> I don't think anyone came up with anything more tasteful to do with that
> hardware, like I say the hardware is itself very hacky.

OK. I guess I was specifically asking about this patch (and the new
usage of ->supply in commit 21e39809fd7c, to some extent). If the
usage of ->supply is the best we can/should do, then we can leave
21e39809fd7c alone. If you don't care to "fix" this log message, then
I can forget about $subject patch too.

Or, do you only want me to improve the commit message (drop the Fixes,
mention bypass mode, etc.) and resubmit?

Brian