linux-kernel - Re: [PATCH] drm/msm: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65f56c2b-591a-16c8-7f3a-41695b1147b3@linaro.org>
Date:   Fri, 3 Sep 2021 21:51:47 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     cgel.zte@...il.com, robdclark@...il.com
Cc:     sean@...rly.run, airlied@...ux.ie, daniel@...ll.ch,
        lyude@...hat.com, airlied@...hat.com,
        laurent.pinchart@...asonboard.com, chi.minghao@....com.cn,
        treding@...dia.com, linux-arm-msm@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>,
        Alexey Minnekhanov <alexeymin@...tmarketos.org>,
        Brian Masney <masneyb@...tation.org>
Subject: Re: [PATCH] drm/msm: remove unneeded variable

On 31/08/2021 14:51, cgel.zte@...il.com wrote:
> From: Chi Minghao <chi.minghao@....com.cn>
> 
> Fix the following coccicheck REVIEW:
> ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Chi Minghao <chi.minghao@....com.cn>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

Glancing on msm/edp, as it was never supported by the in-kernel dts I 
wonder: maybe we should drop it completely? If the need arises the 
removal can be reverted anytime.

Does anybody hacking 8084/8074/8974 support has eDP port access?

> ---
>   drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> index 4fb397ee7c84..3610e26e62fa 100644
> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> @@ -1242,8 +1242,6 @@ bool msm_edp_ctrl_panel_connected(struct edp_ctrl *ctrl)
>   int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
>   		struct drm_connector *connector, struct edid **edid)
>   {
> -	int ret = 0;
> -
>   	mutex_lock(&ctrl->dev_mutex);
>   
>   	if (ctrl->edid) {
> @@ -1278,7 +1276,7 @@ int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
>   	}
>   unlock_ret:
>   	mutex_unlock(&ctrl->dev_mutex);
> -	return ret;
> +	return 0;
>   }
>   
>   int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,
> 


-- 
With best wishes
Dmitry