linux-kernel - security/integrity/platform_certs/keyring_handler.c:62:30: warning: no previous prototype for function 'get_handler_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202109040349.OzWX0LjY-lkp@intel.com>
Date:   Sat, 4 Sep 2021 03:34:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Atish Patra <atish.patra@....com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Palmer Dabbelt <palmerdabbelt@...gle.com>,
        Ard Biesheuvel <ardb@...nel.org>
Subject: security/integrity/platform_certs/keyring_handler.c:62:30: warning:
 no previous prototype for function 'get_handler_for_db'

Hi Atish,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a9c9a6f741cdaa2fa9ba24a790db8d07295761e3
commit: d7071743db31b4f6898b1c742e4b451bb4bc4b02 RISC-V: Add EFI stub support.
date:   11 months ago
config: riscv-randconfig-r022-20210904 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 1104e3258b5064e7110cc297e2cec60ac9acfc0a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d7071743db31b4f6898b1c742e4b451bb4bc4b02
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout d7071743db31b4f6898b1c742e4b451bb4bc4b02
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> security/integrity/platform_certs/keyring_handler.c:62:30: warning: no previous prototype for function 'get_handler_for_db' [-Wmissing-prototypes]
   __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
                                ^
   security/integrity/platform_certs/keyring_handler.c:62:8: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
          ^
          static 
>> security/integrity/platform_certs/keyring_handler.c:73:30: warning: no previous prototype for function 'get_handler_for_dbx' [-Wmissing-prototypes]
   __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)
                                ^
   security/integrity/platform_certs/keyring_handler.c:73:8: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)
          ^
          static 
   2 warnings generated.


vim +/get_handler_for_db +62 security/integrity/platform_certs/keyring_handler.c

ad723674d67584 Nayna Jain 2019-11-10  57  
ad723674d67584 Nayna Jain 2019-11-10  58  /*
ad723674d67584 Nayna Jain 2019-11-10  59   * Return the appropriate handler for particular signature list types found in
ad723674d67584 Nayna Jain 2019-11-10  60   * the UEFI db and MokListRT tables.
ad723674d67584 Nayna Jain 2019-11-10  61   */
ad723674d67584 Nayna Jain 2019-11-10 @62  __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
ad723674d67584 Nayna Jain 2019-11-10  63  {
ad723674d67584 Nayna Jain 2019-11-10  64  	if (efi_guidcmp(*sig_type, efi_cert_x509_guid) == 0)
ad723674d67584 Nayna Jain 2019-11-10  65  		return add_to_platform_keyring;
ad723674d67584 Nayna Jain 2019-11-10  66  	return 0;
ad723674d67584 Nayna Jain 2019-11-10  67  }
ad723674d67584 Nayna Jain 2019-11-10  68  
ad723674d67584 Nayna Jain 2019-11-10  69  /*
ad723674d67584 Nayna Jain 2019-11-10  70   * Return the appropriate handler for particular signature list types found in
ad723674d67584 Nayna Jain 2019-11-10  71   * the UEFI dbx and MokListXRT tables.
ad723674d67584 Nayna Jain 2019-11-10  72   */
ad723674d67584 Nayna Jain 2019-11-10 @73  __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)

:::::: The code at line 62 was first introduced by commit
:::::: ad723674d6758478829ee766e3f1a2a24d56236f x86/efi: move common keyring handler functions to new file

:::::: TO: Nayna Jain <nayna@...ux.ibm.com>
:::::: CC: Michael Ellerman <mpe@...erman.id.au>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (29555 bytes)