linux-kernel - Re: [PATCH] qlcnic: Remove redundant unlock in qlcnic_pinit_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163074960567.20299.3371264143272818975.git-patchwork-notify@kernel.org>
Date:   Sat, 04 Sep 2021 10:00:05 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, shshaikh@...vell.com, manishc@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, davem@...emloft.net, kuba@...nel.org,
        sony.chacko@...gic.com, anirban.chakraborty@...gic.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri,  3 Sep 2021 15:35:43 +0800 you wrote:
> Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
> in qlcnic_pinit_from_rom(), but remains its corresponding
> unlock function, which is odd. I'm not very sure whether the
> lock is missing, or the unlock is redundant. This bug is
> suggested by a static analysis tool, please advise.
> 
> Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> 
> [...]

Here is the summary with links:
  - qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
    https://git.kernel.org/netdev/net/c/9ddbc2a00d7f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html