linux-kernel - Re: [possible bug] missed wakeup in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whho2pj4Au+rVpTGkoj7nJCEJwSfikLQVHDZ8kbKG7U1w@mail.gmail.com>
Date:   Sat, 4 Sep 2021 09:59:47 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [possible bug] missed wakeup in do_sigtimedwait()?

On Sat, Sep 4, 2021 at 7:45 AM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> Looks like that __set_current_state() should've been done before dropping
> the siglock.  Am I missing something subtle here?

I agree, that seems like a bug, and your fix seems the trivially correct thing.

The bug goes back at least before ther bk history (in 2002).
Presumably since the introduction of the system call.

         Linus