linux-kernel - Re: [PATCH] staging: r8188eu: core: remove condition never execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Sep 2021 18:53:28 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Saurav Girepunje <saurav.girepunje@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove condition never execute

On Sat, 4 Sept 2021 at 13:50, Saurav Girepunje
<saurav.girepunje@...il.com> wrote:
>
> Remove condition which never get execute.
> as pattrib->mdata is always zero before if condition check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> ---
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 4178b3c1ff57..f314f55997bf 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
>         else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
>                 SetToDs(fctrl);
>
> -       if (pattrib->mdata)
> -               SetMData(fctrl);
> -
>         qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
>
>         SetPriority(qc, tid);
> --
> 2.32.0
>

Thanks for this.

Acked-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil