linux-kernel - Re: [PATCH 0/6] staging: r8188eu: remove some functions from hal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA=Fs0ntWh8kanSBMA+jBLHAgVTAjH7SFJ8ROrmncZTkzSy-gQ@mail.gmail.com>
Date:   Sat, 4 Sep 2021 19:27:22 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Martin Kaiser <martin@...ser.cx>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/6] staging: r8188eu: remove some functions from hal_ops

On Sat, 4 Sept 2021 at 13:40, Michael Straube <straube.linux@...il.com> wrote:
>
> Getting rid of the hal layer is on the todo list. This series
> removes some functions from hal_ops and make the driver call the
> pointed functions directly.
>
> Tested with Inter-Tech DMG-02.
>
> Michael Straube (6):
>   staging: r8188eu: remove intf_chip_configure from hal_ops
>   staging: r8188eu: remove read_adapter_info from hal_ops
>   staging: r8188eu: remove read_chip_version from hal_ops
>   staging: r8188eu: remove wrapper around ReadChipVersion8188E()
>   staging: r8188eu: remove GetHalODMVarHandler from hal_ops
>   staging: r8188eu: remove init_default_value from hal_ops
>
>  drivers/staging/r8188eu/hal/hal_intf.c        | 33 -------------------
>  .../staging/r8188eu/hal/rtl8188e_hal_init.c   | 16 +--------
>  drivers/staging/r8188eu/hal/usb_halinit.c     | 10 ++----
>  drivers/staging/r8188eu/include/hal_intf.h    | 22 +++----------
>  .../staging/r8188eu/include/rtl8188e_hal.h    |  2 ++
>  drivers/staging/r8188eu/os_dep/os_intfs.c     |  4 +--
>  drivers/staging/r8188eu/os_dep/usb_intf.c     |  7 ++--
>  7 files changed, 16 insertions(+), 78 deletions(-)
>
> --
> 2.33.0
>

Dear Michael,

Looks good to me, built and tested here:
Acked-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil