linux-kernel - Re: [PATCH v2 0/3] staging: r8188eu: Shorten and simplify calls chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 05 Sep 2021 00:11:30 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] staging: r8188eu: Shorten and simplify calls chain

On Saturday, September 4, 2021 11:27:16 PM CEST Fabio M. De Francesco wrote:
> io_ops abstraction is useless in this driver, since there is only one ops
> registration. Without io_ops we can get rid of indirect calls mess and
> shorten the calls chain.
> 
> Shorten the calls chain of rtw_read8/16/32() down to the actual reads.
> For this purpose unify the three usb_read8/16/32 into the new
> usb_read(); make the latter parametrizable with 'size'; embed most of
> the code of usbctrl_vendorreq() into usb_read() and use in it the new
> usb_control_msg_recv() API of USB Core.
> 
> Shorten the calls chain of rtw_write8/16/32() down to the actual writes.
> For this purpose unify the four usb_write8/16/32/N() into the new
> usb_write(); make the latter parametrizable with 'size'; embed most of
> the code of usbctrl_vendorreq() into usb_write() and use in it the new
> usb_control_msg_send() API of USB Core.
> 
> The code with the modifications was thoroughly tested by Pavel Skripkin 
> using a TP-Link TL-WN722N v2 / v3 [Realtek RTL8188EUS]
> 
> Fabio M. De Francesco (2):
>   staging: r8188eu: Shorten calls chain of rtw_read8/16/32()
>   staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N()
> 
> Pavel Skripkin (1):
>   staging: r8188eu: remove _io_ops structure
> 
>  drivers/staging/r8188eu/core/rtw_io.c         | 241 +----------------
>  drivers/staging/r8188eu/hal/usb_halinit.c     |   6 +-
>  drivers/staging/r8188eu/hal/usb_ops_linux.c   | 242 +++++++++++-------
>  drivers/staging/r8188eu/include/rtw_io.h      |  76 +-----
>  drivers/staging/r8188eu/include/usb_ops.h     |   2 -
>  .../staging/r8188eu/include/usb_ops_linux.h   |   8 -
>  drivers/staging/r8188eu/os_dep/usb_intf.c     |   2 +-
>  .../staging/r8188eu/os_dep/usb_ops_linux.c    |  40 +--
>  8 files changed, 174 insertions(+), 443 deletions(-)
> 
> -- 
> 2.33.0
> 
Dear Maintainers,

Stupid mistakes on mistakes... Please discard this revision of the series 
because patch 3/3 is missing the version number.

Thanks,

Fabio