linux-kernel - Re: [RFC PATCH] drivers/nvdimm: nvdimm_pmu_free_hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d314a25-8972-3a01-9402-d43e41177a8f@linux.ibm.com>
Date:   Sat, 4 Sep 2021 12:09:59 +0530
From:   kajoljain <kjain@...ux.ibm.com>
To:     kernel test robot <lkp@...el.com>, mpe@...erman.id.au,
        linuxppc-dev@...ts.ozlabs.org, nvdimm@...ts.linux.dev,
        linux-kernel@...r.kernel.org, peterz@...radead.org,
        dan.j.williams@...el.com, ira.weiny@...el.com,
        vishal.l.verma@...el.com
Cc:     kbuild-all@...ts.01.org, maddy@...ux.ibm.com, santosh@...six.org
Subject: Re: [RFC PATCH] drivers/nvdimm: nvdimm_pmu_free_hotplug_memory() can
 be static



On 9/3/21 8:49 PM, kernel test robot wrote:
> drivers/nvdimm/nd_perf.c:159:6: warning: symbol 'nvdimm_pmu_free_hotplug_memory' was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
>  nd_perf.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
> index 4c49d1bc2a3c6..b129e5e702d59 100644
> --- a/drivers/nvdimm/nd_perf.c
> +++ b/drivers/nvdimm/nd_perf.c
> @@ -156,7 +156,7 @@ static int nvdimm_pmu_cpu_hotplug_init(struct nvdimm_pmu *nd_pmu)
>  	return 0;
>  }
>  
> -void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
> +static void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
>  {
>  	cpuhp_state_remove_instance_nocalls(nd_pmu->cpuhp_state, &nd_pmu->node);
>  	cpuhp_remove_multi_state(nd_pmu->cpuhp_state);
> 

Hi,
   Thanks for reporting this issue, I will merge it in my followup patchset.

Thanks,
Kajol Jain