linux-kernel - Re: [PATCH 4/8] clk: sunxi-ng: Rename files to match Kconfig and drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163087508158.405991.8011400324694193509@swboyd.mtv.corp.google.com>
Date:   Sun, 05 Sep 2021 13:51:21 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Maxime Ripard <maxime@...no.tech>,
        Samuel Holland <samuel@...lland.org>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] clk: sunxi-ng: Rename files to match Kconfig and drivers

Quoting Samuel Holland (2021-09-03 13:57:14)
> Hi Maxime,
> 
> On 9/3/21 4:10 AM, Maxime Ripard wrote:
> > Hi,
> > 
> > On Wed, Sep 01, 2021 at 12:05:22AM -0500, Samuel Holland wrote:
> >> When the drivers are built as modules, the file name will become the
> >> module name. Rename the files so everything matches: the Kconfig symbol,
> >> the platform driver name (as seen in sysfs), and the module name.
> >>
> >> Signed-off-by: Samuel Holland <samuel@...lland.org>
> > 
> > I'm not a big fan of big renames like this, it makes merging and
> > backporting patches harder in the long term.
> 
> I can split this into two commits, first the .c files and then the .h
> files, so everything is a 100% rename, if that makes a difference.
> 
> > I assume you did this to make the module autoloading work? If so, using
> > MODULE_ALIAS would be less intrusive
> 
> Autoloading should work anyway, since there is a module alias for the
> compatible string. This change is more about the principle of least
> surprise. The compatible is allwinner,sun50i-a64-ccu, the Kconfig symbol
> is SUN50I_A64_CCU, the driver name (in /sys/bus/platform/drivers) is
> sun50i_a64_ccu, but yet the module name is ccu-sun50i-a64???
> 
> Once we allow building modules, the names are ABI, and this
> inconsistency will bother me until the end of time :)
> 
> If there is a way to completely rename the module without renaming the
> files (not adding an alias), then that would be enough for me.

Yes. You have to use Makefile logic to make an object manually that
renames the old one. The linker will build oldname.o as
new-module-name.o and then make a .ko out of it if the final goal is a
module.

  new-module-name-y := oldname.o
  obj-$(CONFIG_YOUR_SYMBOL_HERE) += new-module-name.o