linux-kernel - Re: [PATCH v2 7/9] perf cs-etm: Create ETE decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ9a7VhF2xPC70GG_66Q-jduYuit3YUBVUKLE=gNp2JXj_9jVg@mail.gmail.com>
Date:   Sun, 5 Sep 2021 22:24:39 +0100
From:   Mike Leach <mike.leach@...aro.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Suzuki K Poulose <suzuki.poulose@....com>,
        James Clark <james.clark@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Coresight ML <coresight@...ts.linaro.org>,
        linux-perf-users@...r.kernel.org,
        John Garry <john.garry@...wei.com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 7/9] perf cs-etm: Create ETE decoder

Reviewed-by: Mike Leach <mike.leach@...aro.org>


On Fri, 3 Sept 2021 at 12:16, Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> Em Fri, Sep 03, 2021 at 10:15:07AM +0100, Suzuki K Poulose escreveu:
> > On 06/08/2021 14:41, James Clark wrote:
> > > If the magic number indicates ETE instantiate a OCSD_BUILTIN_DCD_ETE
> > > decoder instead of OCSD_BUILTIN_DCD_ETMV4I. ETE is the new trace feature
> > > for Armv9.
> > >
> > > Testing performed
> > > =================
> > >
> > > * Old files with v0 and v1 headers for ETMv4 still open correctly
> > > * New files with new magic number open on new versions of perf
> > > * New files with new magic number fail to open on old versions of perf
> > > * Decoding with the ETE decoder results in the same output as the ETMv4
> > >    decoder as long as there are no new ETE packet types
> > >
> > > Signed-off-by: James Clark <james.clark@....com>
> >
> > Changes look good to me with my limited knowledge about the decoder
> > facing code.
> >
> > FWIW,
> >
> > Acked-by: Suzuki K Poulose <suzuki.poulose@....com>
>
> Thanks, collected the Acked-by.
>
> - Arnaldo



--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK