linux-kernel - Re: [PATCH] iio: adc: ti-ads8344: convert probe to device-managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210905115648.5c02df3d@jic23-huawei>
Date:   Sun, 5 Sep 2021 11:56:48 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexandru Ardelean <aardelean@...iqon.com>
Cc:     linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        Gregory CLEMENT <gregory.clement@...tlin.com>
Subject: Re: [PATCH] iio: adc: ti-ads8344: convert probe to device-managed

On Fri,  3 Sep 2021 10:37:07 +0300
Alexandru Ardelean <aardelean@...iqon.com> wrote:

> This change converts the driver to register via devm_iio_device_register().
> The regulator disable is moved on a devm_add_action_or_reset() hook.
> 
> And the spi_set_drvdata() isn't required anymore.
> And finally, the ads8344_remove() can be removed as well.
> 
> Signed-off-by: Alexandru Ardelean <aardelean@...iqon.com>

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to see if it can find anything we missed. 
> ---
>  drivers/iio/adc/ti-ads8344.c | 27 ++++++++-------------------
>  1 file changed, 8 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads8344.c b/drivers/iio/adc/ti-ads8344.c
> index a345a30d74fa..c96d2a9ba924 100644
> --- a/drivers/iio/adc/ti-ads8344.c
> +++ b/drivers/iio/adc/ti-ads8344.c
> @@ -133,6 +133,11 @@ static const struct iio_info ads8344_info = {
>  	.read_raw = ads8344_read_raw,
>  };
>  
> +static void ads8344_reg_disable(void *data)
> +{
> +	regulator_disable(data);
> +}
> +
>  static int ads8344_probe(struct spi_device *spi)
>  {
>  	struct iio_dev *indio_dev;
> @@ -161,26 +166,11 @@ static int ads8344_probe(struct spi_device *spi)
>  	if (ret)
>  		return ret;
>  
> -	spi_set_drvdata(spi, indio_dev);
> -
> -	ret = iio_device_register(indio_dev);
> -	if (ret) {
> -		regulator_disable(adc->reg);
> +	ret = devm_add_action_or_reset(&spi->dev, ads8344_reg_disable, adc->reg);
> +	if (ret)
>  		return ret;
> -	}
> -
> -	return 0;
> -}
> -
> -static int ads8344_remove(struct spi_device *spi)
> -{
> -	struct iio_dev *indio_dev = spi_get_drvdata(spi);
> -	struct ads8344 *adc = iio_priv(indio_dev);
> -
> -	iio_device_unregister(indio_dev);
> -	regulator_disable(adc->reg);
>  
> -	return 0;
> +	return devm_iio_device_register(&spi->dev, indio_dev);
>  }
>  
>  static const struct of_device_id ads8344_of_match[] = {
> @@ -195,7 +185,6 @@ static struct spi_driver ads8344_driver = {
>  		.of_match_table = ads8344_of_match,
>  	},
>  	.probe = ads8344_probe,
> -	.remove = ads8344_remove,
>  };
>  module_spi_driver(ads8344_driver);
>