linux-kernel - Re: [PATCH v3 00/40] staging: r8188eu: remove function pointers from struct hal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Sep 2021 01:57:13 +0300
From:   Kari Argillander <kari.argillander@...il.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, martin@...ser.cx, fmdefrancesco@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 00/40] staging: r8188eu: remove function pointers from
 struct hal_ops

On Mon, Sep 06, 2021 at 09:01:43PM +0200, Michael Straube wrote:
> In order to get rid of the HAL layer this series removes the next
> bunch of function pointers from struct hal_ops.
> 
> Also it removes some empty functions and cleans up some minor style
> issues I stumbled upon.
> 
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> 
> v1 -> v2
> Fixed typos in commit messages.
> 
> v2 -> v3
> Added this missing patchset version changelog.

Can you please hold on litle bit longer before you send next patch
series. This will make quite bit traffic on the lists and it does
not add value. Wait for bit for reviewers and after that make new
series. You can even post below yours own messages if you found some
mistake and point out that you will change it when you send next
series. Good hold on time would be 3-7 days with series this big imo.

> 
> Michael Straube (40):
>   staging: r8188eu: remove InitSwLeds from hal_ops
>   staging: r8188eu: remove DeInitSwLeds from hal_ops
>   staging: r8188eu: remove dm_init from hal_ops
>   staging: r8188eu: remove dm_deinit from hal_ops
>   staging: r8188eu: remove SetHalODMVarHandler from hal_ops
>   staging: r8188eu: remove empty functions
>   staging: r8188eu: remove unused function rtw_interface_ps_func()
>   staging: r8188eu: remove interface_ps_func from hal_ops
>   staging: r8188eu: remove hal_dm_watchdog from hal_ops
>   staging: r8188eu: remove set_bwmode_handler from hal_ops
>   staging: r8188eu: remove set_channel_handler from hal_ops
>   staging: r8188eu: remove unused enum hal_intf_ps_func
>   staging: r8188eu: remove Add_RateATid from hal_ops
>   staging: r8188eu: remove hal_power_on from hal_ops
>   staging: r8188eu: remove sreset_init_value from hal_ops
>   staging: r8188eu: remove sreset_reset_value from hal_ops
>   staging: r8188eu: remove silentreset from hal_ops
>   staging: r8188eu: remove sreset_xmit_status_check from hal_ops
>   staging: r8188eu: remove sreset_linked_status_check from hal_ops
>   staging: r8188eu: remove sreset_get_wifi_status from hal_ops
>   staging: r8188eu: remove EfusePowerSwitch from hal_ops
>   staging: r8188eu: rename hal_EfusePowerSwitch_RTL8188E()
>   staging: r8188eu: remove wrapper Efuse_PowerSwitch()
>   staging: r8188eu: remove ReadEFuse from hal_ops
>   staging: r8188eu: remove EFUSEGetEfuseDefinition from hal_ops
>   staging: r8188eu: remove EfuseGetCurrentSize from hal_ops
>   staging: r8188eu: remove empty comments
>   staging: r8188eu: remove Efuse_PgPacketRead from hal_ops
>   staging: r8188eu: remove Efuse_PgPacketWrite from hal_ops
>   staging: r8188eu: remove Efuse_WordEnableDataWrite from hal_ops
>   staging: r8188eu: remove useless assignment
>   staging: r8188eu: remove AntDivBeforeLinkHandler from hal_ops
>   staging: r8188eu: remove AntDivCompareHandler from hal_ops
>   staging: r8188eu: remove empty function rtl8188e_start_thread()
>   staging: r8188eu: remove empty function rtl8188e_stop_thread()
>   staging: r8188eu: remove hal_notch_filter from hal_ops
>   staging: r8188eu: remove free_hal_data from hal_ops
>   staging: r8188eu: remove unused function rtl8188e_clone_haldata()
>   staging: r8188eu: remove SetBeaconRelatedRegistersHandler from hal_ops
>   staging: r8188eu: remove UpdateHalRAMask8188EUsb from hal_ops
> 
>  drivers/staging/r8188eu/core/rtw_ap.c         |   9 +-
>  drivers/staging/r8188eu/core/rtw_cmd.c        |   6 +-
>  drivers/staging/r8188eu/core/rtw_efuse.c      | 182 ++++--------------
>  drivers/staging/r8188eu/core/rtw_mlme.c       |   7 +-
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c   |   5 +-
>  drivers/staging/r8188eu/core/rtw_mp_ioctl.c   |  18 +-
>  drivers/staging/r8188eu/core/rtw_p2p.c        |   4 +-
>  drivers/staging/r8188eu/core/rtw_pwrctrl.c    |   8 -
>  drivers/staging/r8188eu/core/rtw_sta_mgt.c    |   2 +-
>  drivers/staging/r8188eu/core/rtw_wlan_util.c  |   8 +-
>  drivers/staging/r8188eu/hal/hal_intf.c        | 170 +---------------
>  .../staging/r8188eu/hal/rtl8188e_hal_init.c   | 123 +++---------
>  drivers/staging/r8188eu/hal/usb_halinit.c     |  36 +---
>  drivers/staging/r8188eu/include/hal_intf.h    | 123 ++----------
>  .../staging/r8188eu/include/rtl8188e_hal.h    |   5 -
>  drivers/staging/r8188eu/include/rtw_efuse.h   |   9 -
>  drivers/staging/r8188eu/include/rtw_pwrctrl.h |   2 -
>  drivers/staging/r8188eu/os_dep/ioctl_linux.c  |  31 +--
>  drivers/staging/r8188eu/os_dep/os_intfs.c     |  21 +-
>  19 files changed, 142 insertions(+), 627 deletions(-)
> 
> -- 
> 2.33.0
>