linux-kernel - Re: Re: [PATCH] dm raid: add missed unlock in raid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <37fdfa89.be2a1.17bb8e29eee.Coremail.dinghao.liu@zju.edu.cn>
Date:   Mon, 6 Sep 2021 10:14:24 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Heinz Mauelshagen" <heinzm@...hat.com>
Cc:     kjlu@....edu, "Alasdair Kergon" <agk@...hat.com>,
        "Mike Snitzer" <snitzer@...hat.com>, dm-devel@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] dm raid: add missed unlock in raid_ctr


> > On Fri, Sep 3, 2021 at 10:02 AM Dinghao Liu dinghao.liu@....edu.cn> wrote:
> > mddev_unlock() is called on all paths after we call mddev_lock_nointr(),
> > except for three error handling paths, which may cause a deadlock. This
> > bug is suggested by a static analysis tool, please advise.
> > Hi,    
> >     
> >     correct, those unlock calls are missing.    
> >
> >     As we are bailing out after md_run() with lock held,     
> >     we can clean the lot of error paths underneath up by jumping to before
> >     md_stop() and add the mddev_unlock upfront it like:    
    
Thanks for your advice! I will fix this and send a new patch soon.

Regards,
Dinghao