linux-kernel - Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0592ddf-306a-a833-785f-750a601487dd@kernel.dk>
Date:   Sun, 5 Sep 2021 21:04:17 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but
 not used warning

On 9/5/21 8:56 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Thu, 2 Sep 2021 06:35:47 -0600 Jens Axboe <axboe@...nel.dk> wrote:
>>
>> On 8/30/21 3:11 AM, Geert Uytterhoeven wrote:
>>> If CONFIG_BLK_DEBUG_FS=n:
>>>
>>>     block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function]
>>>       274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
>>> 	  |            ^~~~~~~~~
>>>
>>> Fix this by moving dd_queued() just before the sole function that calls
>>> it.  
>>
>> Applied, thanks.
> 
> Can we get this to Linus ASAP as he has now made warnings fatal, so
> this is causing lots of build failures.

Sure, it's actually the only branch I haven't sent off yet today. Will
do so now.

-- 
Jens Axboe