linux-kernel - Re: [linux-rt-devel:linux-5.14.y-rt-rebase 242/262] kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Sep 2021 09:54:00 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [linux-rt-devel:linux-5.14.y-rt-rebase 242/262]
 kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for
 'rt_rwlock_is_contended'

On 2021-09-05 03:00:56 [+0800], kernel test robot wrote:
> >> kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended' [-Wmissing-prototypes]
>      249 | int __sched rt_rwlock_is_contended(rwlock_t *rwlock)
>          |             ^~~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/rt_rwlock_is_contended +249 kernel/locking/spinlock_rt.c
> 
> ca72c3eba593af Thomas Gleixner 2021-08-15  248  
> ca72c3eba593af Thomas Gleixner 2021-08-15 @249  int __sched rt_rwlock_is_contended(rwlock_t *rwlock)
> ca72c3eba593af Thomas Gleixner 2021-08-15  250  {
> ca72c3eba593af Thomas Gleixner 2021-08-15  251  	return rw_base_is_contended(&rwlock->rwbase);
> ca72c3eba593af Thomas Gleixner 2021-08-15  252  }
> ca72c3eba593af Thomas Gleixner 2021-08-15  253  EXPORT_SYMBOL(rt_rwlock_is_contended);
> ca72c3eba593af Thomas Gleixner 2021-08-15  254  

| $ git grep rwlock_is_contended include/linux/rwlock_rt.h  
| include/linux/rwlock_rt.h:#define rwlock_is_contended(lock)             (((void)(lock), 0))

shouldn't we wire it up?

Sebastian