linux-kernel - Re: [PATCH] staging: rtl8712: Move similar execution in to a function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Sep 2021 11:45:47 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Saurav Girepunje <saurav.girepunje@...il.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        fmdefrancesco@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: rtl8712: Move similar execution in to a
 function.

On Mon, Sep 06, 2021 at 12:15:57AM +0530, Saurav Girepunje wrote:
> Move the common execution for read_macreg_hdl, write_macreg_hdl,
> write_bbreg_hdl and write_rfreg_hdl in to a new function
> common_read_write_hdl.

You said _what_ you did here, but not _why_ you did this.

I can't easily see why you did this, please explain it better in the
next version of this patch.

thanks,

greg k-h