linux-kernel - Re: [PATCH] kernel/irq: Make irq_set_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bl569goi.ffs@tglx>
Date:   Mon, 06 Sep 2021 11:50:05 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Hao Peng <flyingpenghao@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/irq: Make irq_set_affinity_hint return the real
 return value

On Mon, Sep 06 2021 at 16:20, Hao Peng wrote:
> irq_set_affinity_hint does not return the return value of
> __irq_set_affinity, which makes the state of functions dependent
> on the return value of irq_set_affinity_hint inconsistent.

No, it does not. The affinity hint has been installed even in the case
that __irq_set_affinity() fails.

Setting the affinity in that function is a best effort operation without
any guarantees and in hindsight this should have never been added to
this function.

Thanks,

        tglx