linux-kernel - Re: [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4cbba0a-b346-628c-36f1-6f7c5d1c1ca1@redhat.com>
Date:   Mon, 6 Sep 2021 12:13:13 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Jia He <justin.he@....com>, Sean Christopherson <seanjc@...gle.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct
 kvm_mmu_page

On 30/08/21 16:53, Jia He wrote:
> After reverting and restoring the fast tlb invalidation patch series,
> the mmio_cached is not removed. Hence a unused field is left in
> kvm_mmu_page.
> 
> Cc: Sean Christopherson <seanjc@...gle.com>
> Signed-off-by: Jia He <justin.he@....com>
> ---
>   arch/x86/kvm/mmu/mmu_internal.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
> index 35567293c1fd..3e6f21c1871a 100644
> --- a/arch/x86/kvm/mmu/mmu_internal.h
> +++ b/arch/x86/kvm/mmu/mmu_internal.h
> @@ -37,7 +37,6 @@ struct kvm_mmu_page {
>   
>   	bool unsync;
>   	u8 mmu_valid_gen;
> -	bool mmio_cached;
>   	bool lpage_disallowed; /* Can't be replaced by an equiv large page */
>   
>   	/*
> 

Queued, thanks.

Paolo