linux-kernel - RE: [PATCH 1/1] scripts/checkpatch.pl: remove warning for pritk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 06 Sep 2021 18:11:09 +0530
From:   Maninder Singh <maninder1.s@...sung.com>
To:     "apw@...onical.com" <apw@...onical.com>,
        "joe@...ches.com" <joe@...ches.com>,
        "dwaipayanray1@...il.com" <dwaipayanray1@...il.com>,
        "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@...sung.com>,
        Vaneet Narang <v.narang@...sung.com>
Subject: RE: [PATCH 1/1] scripts/checkpatch.pl: remove warning for
 pritk_deferred also

Hi,

Any comments?
 
>WARNING: Possible unnecessary KERN_ALERT
>+printk_deferred(KERN_ALERT "checking deferred\n");
> 
>total: 0 errors, 1 warnings, 20 lines checked
> 
>Thus removing warning for printk_deferred also.
> 
>Signed-off-by: Vaneet Narang <v.narang@...sung.com>
>Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
>---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
>diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>index 161ce7fe5d1e..e3bea0d36c10 100755
>--- a/scripts/checkpatch.pl
>+++ b/scripts/checkpatch.pl
>@@ -6252,7 +6252,7 @@ sub process {
>                 }
> 
> # check for logging functions with KERN_<LEVEL>
>-                if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
>+                if ($line !~ /printk(?:_ratelimited|_once|_deferred)?\s*\(/ &&
>                     $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
>                         my $level = $1;
>                         if (WARN("UNNECESSARY_KERN_LEVEL",
>--