linux-kernel - Re: 5.4.143-rt63 fscache_cookie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 06 Sep 2021 09:18:04 -0500
From:   Tom Zanussi <zanussi@...nel.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Gregor Beck <gregor.beck@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        "williams@...hat.com" <williams@...hat.com>
Subject: Re: 5.4.143-rt63 fscache_cookie_hash initialisation

On Mon, 2021-09-06 at 10:36 +0200, Sebastian Andrzej Siewior wrote:
> On 2021-09-06 09:55:59 [+0200], Gregor Beck wrote:
> Your proposed change is
> 
> > index 5508d92e3f8f..cba2a226897f 100644
> > --- a/fs/fscache/cookie.c
> > +++ b/fs/fscache/cookie.c
> > @@ -963,6 +963,6 @@ void __init fscache_cookie_init(void)
> > {
> >        int i;
> > 
> > -       for (i = 0; i < (1 << fscache_cookie_hash_shift) - 1; i++)
> > +       for (i = 0; i < ARRAY_SIZE(fscache_cookie_hash); i++)
> >                INIT_HLIST_BL_HEAD(&fscache_cookie_hash[i]);
> > }
> > 
> 
> So that -1 at the end killed us.
> 
> fscache-initialize-cookie-hash-table-raw-spinlocks.patch was removed
> in
> the v5.6-RT series so this should be applied to 5.4 and 4.19.
> 

OK, thanks, I'll add this to the current 5.4 update.

Tom

> Sebastian