linux-kernel - Re: [PATCH v2] coresight: syscfg: fix compiler warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210906150625.GA1228692@p14s>
Date:   Mon, 6 Sep 2021 09:06:25 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Jian Cai <jiancai@...gle.com>
Cc:     mike.leach@...aro.org, linux@...ck-us.net, dianders@...omium.org,
        mka@...omium.org, manojgupta@...gle.com, llozano@...gle.com,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        clang-built-linux@...glegroups.com,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Leo Yan <leo.yan@...aro.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings

On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> This fixes warnings with -Wimplicit-function-declaration, e.g.
> 
> drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> implicit declaration of function 'kzalloc' [-Werror,
> -Wimplicit-function-declaration]
>         csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
>                              GFP_KERNEL);
> 
> Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Jian Cai <jiancai@...gle.com>
> ---
> 
> Changes v1 -> v2:
>   Format the commit message and add Fixes and Reviewed-by tag.
> 
>  drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
>  1 file changed, 1 insertion(+)
>

I have applied this patch to my local tree.  I will push it to the coresight-next
branch when 5.15-rc1 is published next week.

Thanks,
Mathieu

> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
> index fc0760f55c53..43054568430f 100644
> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
> @@ -5,6 +5,7 @@
>   */
>  
>  #include <linux/platform_device.h>
> +#include <linux/slab.h>
>  
>  #include "coresight-config.h"
>  #include "coresight-etm-perf.h"
> -- 
> 2.33.0.259.gc128427fd7-goog
>