linux-kernel - Re: [PATCH] staging: r8188eu: core: remove duplicate structure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4537b0fd-848e-5188-823b-3a3bb750391d@gmail.com>
Date:   Mon, 6 Sep 2021 22:10:04 +0530
From:   Saurav Girepunje <saurav.girepunje@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     saurav.girepunje@...mail.com, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, straube.linux@...il.com,
        fmdefrancesco@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: core: remove duplicate structure.



On 06/09/21 7:19 pm, Greg KH wrote:
> On Sun, Sep 05, 2021 at 04:33:10PM +0530, Saurav Girepunje wrote:
>> Remove duplicate structure mlme_handler and action_handler. Both
>> structure are having same member. Replace it with mlme_action_handler.
> 
> Why merge both names together?  Why not just pick one name and stick
> with that if they really do the same thing?
> 
> thanks,
> 
> greg k-h
> 

Yes, we can pick one name also . I think action_handler name will be better.

Thanks for review Greg,


Regards,
Saurav Girepunje