linux-kernel - Re: [PATCH] block: include dd_queued{,_show} into proper BLK_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHtYXivVcodcR5b2aYnFvhgAJ7yEr0+jYzPZ+w-JxRRzuWJyfA@mail.gmail.com>
Date:   Mon, 6 Sep 2021 14:36:00 -0300
From:   Julio Faracco <jfaracco@...hat.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: include dd_queued{,_show} into proper BLK_DEBUG_FS guard

Thanks Jens.

On Mon, Sep 6, 2021 at 1:44 PM Jens Axboe <axboe@...nel.dk> wrote:
>
> On 9/6/21 10:38 AM, Julio Faracco wrote:
> > This commit fixes a compilation issue to an unused function if
> > BLK_DEBUG_FS setting is not enabled. This usually happens in tiny
> > kernels with several debug options disabled. For further details,
> > see the message below:
> >
> > ../block/mq-deadline.c:274:12: error: ‘dd_queued’ defined but not used [-Werror=unused-function]
> >   274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
> >       |            ^~~~~~~~~
> > cc1: all warnings being treated as errors
>
> This is like the 10th one of these... The patch has been queued up for
> about a week, if you check linux-next or the block tree. It's going
> upstream soon, in fact it was already sent in yesterday.

I noticed after seeing the same patch earlier this morning, but it was
too late to undo.
Discard my patch, pls.

>
> --
> Jens Axboe
>

--
Julio Faracco