linux-kernel - [hverkuil-media:extron 11/12] drivers/media/cec/usb/extron/extron-cec-drv.c:137:14: warning: variable 'has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 7 Sep 2021 02:13:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [hverkuil-media:extron 11/12]
 drivers/media/cec/usb/extron/extron-cec-drv.c:137:14: warning: variable
 'has_edid' set but not used

tree:   git://linuxtv.org/hverkuil/media_tree.git extron
head:   ba505976b52f2f459c285256bbdef1be1f6b9a63
commit: 51b8c46d2deac018101cc49c0e045b58eccc92a7 [11/12] extron-cec: support Hdcp message to determine EDID presence
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add hverkuil-media git://linuxtv.org/hverkuil/media_tree.git
        git fetch --no-tags hverkuil-media extron
        git checkout 51b8c46d2deac018101cc49c0e045b58eccc92a7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/media/cec/usb/extron/extron-cec-drv.c: In function 'extron_irq_work_handler':
>> drivers/media/cec/usb/extron/extron-cec-drv.c:137:14: warning: variable 'has_edid' set but not used [-Wunused-but-set-variable]
     137 |         bool has_edid;
         |              ^~~~~~~~
   drivers/media/cec/usb/extron/extron-cec-drv.c:136:14: warning: variable 'update_has_edid' set but not used [-Wunused-but-set-variable]
     136 |         bool update_has_edid;
         |              ^~~~~~~~~~~~~~~


vim +/has_edid +137 drivers/media/cec/usb/extron/extron-cec-drv.c

   126	
   127	static void extron_irq_work_handler(struct work_struct *work)
   128	{
   129		struct extron_port *port =
   130			container_of(work, struct extron_port, irq_work);
   131		unsigned long flags;
   132		bool update_pa;
   133		u16 pa;
   134		bool update_has_signal;
   135		bool has_signal;
   136		bool update_has_edid;
 > 137		bool has_edid;
   138		u32 status;
   139	
   140		spin_lock_irqsave(&port->msg_lock, flags);
   141		while (port->rx_msg_num) {
   142			spin_unlock_irqrestore(&port->msg_lock, flags);
   143			if (debug)
   144				dev_info(port->dev, "adap received %*ph\n",
   145					 port->rx_msg[port->rx_msg_cur_idx].len,
   146					 port->rx_msg[port->rx_msg_cur_idx].msg);
   147			cec_received_msg(port->adap,
   148					 &port->rx_msg[port->rx_msg_cur_idx]);
   149			spin_lock_irqsave(&port->msg_lock, flags);
   150			if (port->rx_msg_num)
   151				port->rx_msg_num--;
   152			port->rx_msg_cur_idx =
   153				(port->rx_msg_cur_idx + 1) % NUM_MSGS;
   154		}
   155		update_pa = port->update_phys_addr;
   156		pa = port->phys_addr;
   157		port->update_phys_addr = false;
   158		update_has_signal = port->update_has_signal;
   159		has_signal = port->has_signal;
   160		port->update_has_signal = false;
   161		update_has_edid = port->update_has_edid;
   162		has_edid = port->has_edid;
   163		port->update_has_edid = false;
   164		status = port->tx_done_status;
   165		port->tx_done_status = 0;
   166		spin_unlock_irqrestore(&port->msg_lock, flags);
   167	
   168		if (status)
   169			cec_transmit_done(port->adap, status, 0, 0, 0, 0);
   170	
   171		if (update_has_signal && port->is_input)
   172	        	v4l2_ctrl_s_ctrl(port->ctrl_rx_power_present, has_signal);
   173	
   174		if (update_pa) {
   175			cec_s_phys_addr(port->adap, pa, false);
   176			port->extron->edid_reading = false;
   177			port->edid_blocks = 0;
   178			port->read_edid = false;
   179			if (!port->is_input) {
   180				v4l2_ctrl_s_ctrl(port->ctrl_tx_hotplug,
   181						 pa != CEC_PHYS_ADDR_INVALID);
   182				v4l2_ctrl_s_ctrl(port->ctrl_tx_edid_present,
   183						 port->has_edid);
   184			}
   185		}
   186	}
   187	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (60072 bytes)