lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Sep 2021 09:08:01 +0900 From: Sergey Senozhatsky <senozhatsky@...omium.org> To: Colin King <colin.king@...onical.com> Cc: Namjae Jeon <linkinjeon@...nel.org>, Sergey Senozhatsky <senozhatsky@...omium.org>, Steve French <sfrench@...ba.org>, Hyunchul Lee <hyc.lee@...il.com>, linux-cifs@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][next] ksmbd: add missing assignments to ret on ndr_read_int64 read calls On (21/09/06 14:44), Colin King wrote: [..] > @@ -275,11 +275,11 @@ int ndr_decode_dos_attr(struct ndr *n, struct xattr_dos_attrib *da) > if (ret) > return ret; > > - ndr_read_int64(n, NULL); > + ret = ndr_read_int64(n, NULL); > if (ret) > return ret; > > - ndr_read_int64(n, NULL); > + ret = ndr_read_int64(n, NULL); > if (ret) > return ret; A pretty nice catch by that static analyzer tool. Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>
Powered by blists - more mailing lists