linux-kernel - Re: [PATCH] mm/kmemleak: allow __GFP_NOLOCKDEP passed to kmemleak's gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YTcTinqat08VK+xP@arm.com>
Date:   Tue, 7 Sep 2021 08:23:54 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Naohiro Aota <naohiro.aota@....com>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        "Darrick J . Wong" <djwong@...nel.org>, linux-xfs@...r.kernel.org
Subject: Re: [PATCH] mm/kmemleak: allow __GFP_NOLOCKDEP passed to kmemleak's
 gfp

On Tue, Sep 07, 2021 at 02:56:59PM +0900, Naohiro Aota wrote:
> In a memory pressure situation, I'm seeing the lockdep WARNING below.
> Actually, this is similar to a known false positive which is already
> addressed by commit 6dcde60efd94 ("xfs: more lockdep whackamole with
> kmem_alloc*").
> 
> This warning still persists because it's not from kmalloc() itself but
> from an allocation for kmemleak object. While kmalloc() itself suppress
> the warning with __GFP_NOLOCKDEP, gfp_kmemleak_mask() is dropping the
> flag for the kmemleak's allocation.
> 
> Allow __GFP_NOLOCKDEP to be passed to kmemleak's allocation, so that the
> warning for it is also suppressed.
> 
>   ======================================================
>   WARNING: possible circular locking dependency detected
>   5.14.0-rc7-BTRFS-ZNS+ #37 Not tainted

Acked-by: Catalin Marinas <catalin.marinas@....com>