linux-kernel - Re: [PATCH v2] USB: cdc-acm: fix minor-number release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73080713-d1d1-b93f-a837-a5af02b698ad@suse.com>
Date:   Tue, 7 Sep 2021 10:53:18 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Jaejoong Kim <climbbb.kim@...il.com>
Subject: Re: [PATCH v2] USB: cdc-acm: fix minor-number release


On 07.09.21 10:23, Johan Hovold wrote:
> If the driver runs out of minor numbers it would release minor 0 and
> allow another device to claim the minor while still in use.
>
> Fortunately, registering the tty class device of the second device would
> fail (with a stack dump) due to the sysfs name collision so no memory is
> leaked.
>
> Fixes: cae2bc768d17 ("usb: cdc-acm: Decrement tty port's refcount if probe() fail")
> Cc: stable@...r.kernel.org      # 4.19
> Cc: Jaejoong Kim <climbbb.kim@...il.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
Acked-by: Oliver Neukum <oneukum@...e.com>