linux-kernel - RE: [PATCH] trap: Fix warning comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0bcb01d7a38f$48dd1c20$da975460$@codeaurora.org>
Date:   Mon, 6 Sep 2021 21:23:01 -0500
From:   "Brian Cain" <bcain@...eaurora.org>
To:     "'Jiapeng Chong'" <jiapeng.chong@...ux.alibaba.com>
Cc:     <linux-hexagon@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] trap: Fix warning comparing pointer to 0

> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> Sent: Monday, September 6, 2021 4:33 AM
> To: bcain@...eaurora.org
> Cc: linux-hexagon@...r.kernel.org; linux-kernel@...r.kernel.org;
> chongjiapeng <jiapeng.chong@...ux.alibaba.com>
> Subject: [PATCH] trap: Fix warning comparing pointer to 0
> 
> From: chongjiapeng <jiapeng.chong@...ux.alibaba.com>
> 
> Fix the following coccicheck warning:
> 
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: chongjiapeng <jiapeng.chong@...ux.alibaba.com>
> ---
>  arch/hexagon/kernel/traps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index edfc35d..3b6e0de 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
>  		}
> 
>  		/* Attempt to continue past exception. */
> -		if (0 == newfp) {
> +		if (!newfp) {
>  			struct pt_regs *regs = (struct pt_regs *) (((void
*)fp)
>  						+ 8);
> 

Reviewed-by: Brian Cain <bcain@...eaurora.org>