linux-kernel - Re: [PATCH] usb: ehci: Simplify platform driver registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202109071816.ALAT868S-lkp@intel.com>
Date:   Tue, 7 Sep 2021 18:56:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Alan Stern <stern@...land.harvard.edu>
Cc:     kbuild-all@...ts.01.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] usb: ehci: Simplify platform driver registration

Hi Guenter,

I love your patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.14 next-20210907]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Guenter-Roeck/usb-ehci-Simplify-platform-driver-registration/20210907-124747
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: alpha-randconfig-r023-20210906 (attached as .config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bd9aa6646a29d48171474905fedca85ac7ff6ce5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Guenter-Roeck/usb-ehci-Simplify-platform-driver-registration/20210907-124747
        git checkout bd9aa6646a29d48171474905fedca85ac7ff6ce5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/usb/host/ehci-hcd.c: In function 'ehci_hcd_init':
>> drivers/usb/host/ehci-hcd.c:1340:18: error: implicit declaration of function 'platform_register_drivers'; did you mean 'pci_register_driver'? [-Werror=implicit-function-declaration]
    1340 |         retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
         |                  ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                  pci_register_driver
   drivers/usb/host/ehci-hcd.c: In function 'ehci_hcd_cleanup':
>> drivers/usb/host/ehci-hcd.c:1357:9: error: implicit declaration of function 'platform_unregister_drivers'; did you mean 'pci_unregister_driver'? [-Werror=implicit-function-declaration]
    1357 |         platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         |         pci_unregister_driver
   cc1: some warnings being treated as errors


vim +1340 drivers/usb/host/ehci-hcd.c

  1339	
> 1340		retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
  1341		if (retval < 0)
  1342			goto clean0;
  1343		return 0;
  1344	
  1345	clean0:
  1346	#ifdef CONFIG_DYNAMIC_DEBUG
  1347		debugfs_remove(ehci_debug_root);
  1348		ehci_debug_root = NULL;
  1349	#endif
  1350		clear_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
  1351		return retval;
  1352	}
  1353	module_init(ehci_hcd_init);
  1354	
  1355	static void __exit ehci_hcd_cleanup(void)
  1356	{
> 1357		platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35624 bytes)