linux-kernel - Re: [PATCH v2 5/5] ARM: multi_v7_defconfig: Add support for Airoha EN7523 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1e064f4-702f-c794-6a61-28608e7acadb@gmail.com>
Date:   Tue, 7 Sep 2021 14:03:08 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Bert Vermeulen <bert@...t.com>
Cc:     devicetree@...r.kernel.org, John Crispin <john@...ozen.org>,
        Russell King <linux@...linux.org.uk>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Arnd Bergmann <arnd@...db.de>,
        Olivier Moysan <olivier.moysan@...com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Fabrice Gasnier <fabrice.gasnier@...com>,
        Lionel Debieve <lionel.debieve@...com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Stefan Wahren <stefan.wahren@...e.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] ARM: multi_v7_defconfig: Add support for Airoha
 EN7523 SoC

07.09.2021 13:41, Bert Vermeulen пишет:
> On 9/7/21 12:39 PM, Dmitry Osipenko wrote:
>> 07.09.2021 13:27, Bert Vermeulen пишет:
>>> From: John Crispin <john@...ozen.org>
>>>
>>> This enables basic bootup support for the Airoha EN7523 SoC.
>>>
>>> Signed-off-by: John Crispin <john@...ozen.org>
>>> Signed-off-by: Bert Vermeulen <bert@...t.com>
>>> ---
>>>  arch/arm/configs/multi_v7_defconfig | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/configs/multi_v7_defconfig
>>> b/arch/arm/configs/multi_v7_defconfig
>>> index d9abaae118dd..a9370a95dc38 100644
>>> --- a/arch/arm/configs/multi_v7_defconfig
>>> +++ b/arch/arm/configs/multi_v7_defconfig
>>> @@ -31,6 +31,7 @@ CONFIG_MACH_BERLIN_BG2=y
>>>  CONFIG_MACH_BERLIN_BG2CD=y
>>>  CONFIG_MACH_BERLIN_BG2Q=y
>>>  CONFIG_ARCH_DIGICOLOR=y
>>> +CONFIG_ARCH_AIROHA=y
>>>  CONFIG_ARCH_EXYNOS=y
>>>  CONFIG_ARCH_HIGHBANK=y
>>>  CONFIG_ARCH_HISI=y
>>> @@ -983,6 +984,7 @@ CONFIG_STAGING_BOARD=y
>>>  CONFIG_MFD_CROS_EC_DEV=m
>>>  CONFIG_CROS_EC_I2C=m
>>>  CONFIG_CROS_EC_SPI=m
>>> +CONFIG_COMMON_CLK_EN7523=y
>>
>> If SoC doesn't work without clk support, then this option should be
>> auto-selected by the arch option.
>>
>> It also doesn't look like upstream kernel has COMMON_CLK_EN7523 at all.
> 
> Oops, you're right -- the clock driver is coming as soon as the base
> system is in. I guess this option (under ARCH_AIROHA) should come in at
> that time as well? I'll respin after some more comments.

Probably. You may also make clk driver to use ARCH_AIROHA option
directly if driver is supposed to be used only by that single arch, like
some other platform do that.