linux-kernel - Re: [PATCH 1/3] leds:triggers:Extend the kernel panic LED trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210907142018.45b2d114@dellmb>
Date:   Tue, 7 Sep 2021 14:20:18 +0200
From:   Marek Behún <kabel@...nel.org>
To:     chaochao2021666@....com
Cc:     pavel@....cz, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        jan.kiszk@...mens.com, 464759471@...com,
        chao zeng <chao.zeng@...mens.com>
Subject: Re: [PATCH 1/3] leds:triggers:Extend the kernel panic LED trigger

On Mon,  6 Sep 2021 21:53:18 +0800
chaochao2021666@....com wrote:

> From: chao zeng <chao.zeng@...mens.com>
> 
> This commit extend panic trigger, add two new panic trigger
> "panic_on" and "panic_off" and keep the "panic" compatible with
> "panic_blink".
> 
> All the led on the "panic_on" would light and on
> the "panic_off" would turn off

We don't wont gazillion triggers, each for every possible setting.

Instead extend the existing panic trigger to have another sysfs setting
where you can set this behavior.
  echo panic >trigger
  echo blink >on_panic
So the on_panic file can accept "on", "off" or "blink".

Alternatively a pattern could be set as in the ledtrig-pattern trigger.

Also your patches do not use correct spacing in commit titles:
  leds:triggers:Extend the kernel panic LED trigger
should instead be
  leds: triggers: Extend the kernel panic LED trigger

Marek