[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <848905ffa20cf234446b16682cbbcf1e56853950.camel@kernel.org>
Date: Tue, 07 Sep 2021 17:07:14 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: "Luck, Tony" <tony.luck@...el.com>,
Sean Christopherson <seanjc@...gle.com>,
"Hansen, Dave" <dave.hansen@...el.com>
Cc: "Zhang, Cathy" <cathy.zhang@...el.com>,
"x86@...nel.org" <x86@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline
code
On Mon, 2021-09-06 at 18:51 +0000, Luck, Tony wrote:
> On Fri, 2021-09-03 at 09:12 +0300, Jarkko Sakkinen wrote:
> > On Fri, 2021-08-27 at 12:55 -0700, Tony Luck wrote:
> > > +#ifdef CONFIG_X86_SGX
> > > +int sgx_memory_failure(unsigned long pfn, int flags);
> > > +bool sgx_is_epc_page(u64 paddr);
> > > +#else
> > > +static inline int sgx_memory_failure(unsigned long pfn, int flags)
> > > +{
> > > + return -ENXIO;
> > > +}
> > > +
> > > +static inline bool sgx_is_epc_page(u64 paddr)
> > > +{
> > > + return false;
> > > +}
> > > +#endif
> >
> > These decl's should be in arch/x86/include/asm/sgx.h, and as part of
> > patch that contains the implementations.
>
> But I need to use these functions in arch independent code. Specifically in
> mm/memory-failure.c and drivers/acpi/apei/einj.c
>
> If I just #include <asm/sgx.h> in those files I'll break the build for other
> architectures.
What does specifically break the build?
/Jarkko
Powered by blists - more mailing lists