linux-kernel - Re: [PATCH v2] usb: ehci: Simplify platform driver registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210907141352.GA571275@rowland.harvard.edu>
Date:   Tue, 7 Sep 2021 10:13:52 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: ehci: Simplify platform driver registration

On Tue, Sep 07, 2021 at 05:30:02AM -0700, Guenter Roeck wrote:
> Use platform_register_drivers() and platform_unregister_drivers() to
> register and unregister ehci platform drivers. This simplifies the code
> and prevents the following build errors seen with sparc:allmodconfig.
> 
> drivers/usb/host/ehci-hcd.c:1301: error:
> 	"PLATFORM_DRIVER" redefined
> drivers/usb/host/ehci-sh.c:173:31: error:
> 	'ehci_hcd_sh_driver' defined but not used
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> v2: Explicitly include platform_device.h.
>     The ps3 driver is not a platform driver, so we still have
>     to handle it separately.

Acked-by: Alan Stern <stern@...land.harvard.edu>