linux-kernel - Re: [PATCH] blk-throttle: fix UAF by deleteing timer in blk_throtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f962850-06d6-f50b-2c2f-e6d5bfd3823a@kernel.dk>
Date:   Tue, 7 Sep 2021 08:37:06 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Li Jinlin <lijinlin3@...wei.com>, tj@...nel.org
Cc:     cgroups@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linfeilong@...wei.com,
        louhongxiang@...wei.com
Subject: Re: [PATCH] blk-throttle: fix UAF by deleteing timer in
 blk_throtl_exit()

On 9/7/21 6:12 AM, Li Jinlin wrote:
> From: Li Jinlin <lijinlin3@...wei.com>
> 
> The pending timer has been set up in blk_throtl_init(). However, the
> timer is not deleted in blk_throtl_exit(). This means that the timer
> handler may still be running after freeing the timer, which would
> result in a use-after-free.
> 
> Fix by calling del_timer_sync() to delete the timer in blk_throtl_exit().

Applied, thanks.

-- 
Jens Axboe