linux-kernel - Re: [PATCH 05/15] nfc: pn533: drop unneeded debug prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Sep 2021 10:03:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Krzysztof Opasiak <k.opasiak@...sung.com>,
        Mark Greer <mgreer@...malcreek.com>,
        "David S. Miller" <davem@...emloft.net>, linux-nfc@...ts.01.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH 05/15] nfc: pn533: drop unneeded debug prints

On Tue, 7 Sep 2021 18:05:25 +0200 Krzysztof Kozlowski wrote:
> On 07/09/2021 14:18, Krzysztof Kozlowski wrote:
> > ftrace is a preferred and standard way to debug entering and exiting
> > functions so drop useless debug prints.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> > ---
> >  drivers/nfc/pn533/i2c.c   | 1 -
> >  drivers/nfc/pn533/pn533.c | 2 --
> >  2 files changed, 3 deletions(-)
> > 
> > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c
> > index e6bf8cfe3aa7..91d4a035eb63 100644
> > --- a/drivers/nfc/pn533/i2c.c
> > +++ b/drivers/nfc/pn533/i2c.c
> > @@ -138,7 +138,6 @@ static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data)
> >  	}
> >  
> >  	client = phy->i2c_dev;  
> 
> This line should also be removed (reported by kbuild robot).
> 
> I will send a v2.

Dave marked the series as Deferred (although this patch is Changes
Requested, I'm guessing you did that, if so please don't change patch
states in netdev pw), please hold off:


# Form letter - net-next is closed

We have already sent the networking pull request for 5.15
and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.

Please repost when net-next reopens after 5.15-rc1 is cut.

Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html

RFC patches sent for review only are obviously welcome at any time.