linux-kernel - Re: [PATCH v2] coresight: syscfg: fix compiler warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210907175823.GB235361@roeck-us.net>
Date:   Tue, 7 Sep 2021 10:58:23 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Jian Cai <jiancai@...gle.com>,
        Mike Leach <mike.leach@...aro.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Manoj Gupta <manojgupta@...gle.com>,
        Luis Lozano <llozano@...gle.com>, coresight@...ts.linaro.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Leo Yan <leo.yan@...aro.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings

On Tue, Sep 07, 2021 at 10:51:53AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Mon, Sep 6, 2021 at 8:06 AM Mathieu Poirier
> <mathieu.poirier@...aro.org> wrote:
> >
> > On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> > > This fixes warnings with -Wimplicit-function-declaration, e.g.
> > >
> > > drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> > > implicit declaration of function 'kzalloc' [-Werror,
> > > -Wimplicit-function-declaration]
> > >         csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
> > >                              GFP_KERNEL);
> > >
> > > Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> > > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > > Signed-off-by: Jian Cai <jiancai@...gle.com>
> > > ---
> > >
> > > Changes v1 -> v2:
> > >   Format the commit message and add Fixes and Reviewed-by tag.
> > >
> > >  drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> >
> > I have applied this patch to my local tree.  I will push it to the coresight-next
> > branch when 5.15-rc1 is published next week.
> 
> Out of curiosity, does the fact that it'll be in coresight-next mean
> that this will target v5.15 or v5.16? I usually think of "-next"
> branches as targeting one major version later, so I'd assume v5.16?
> ...but it would be nice if this warning could get fixed somewhere in
> v5.15.
> 
Normally "when 5.15-rc1 is published" would imply v5.16.

Note that warnings are now reported as errors in mainline,
since -Werror is now enabled by default.

Guenter