linux-kernel - [PATCH] scsi: ufs-qcom: Remove unneeded code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210907053554.1005-1-cw9316.lee@samsung.com>
Date:   Tue,  7 Sep 2021 14:35:54 +0900
From:   Chanwoo Lee <cw9316.lee@...sung.com>
To:     agross@...nel.org, bjorn.andersson@...aro.org,
        alim.akhtar@...sung.com, avri.altman@....com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-arm-msm@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     grant.jung@...sung.com, jt77.jang@...sung.com,
        dh0421.hwang@...sung.com, sh043.lee@...sung.com,
        ChanWoo Lee <cw9316.lee@...sung.com>
Subject: [PATCH] scsi: ufs-qcom: Remove unneeded code

From: ChanWoo Lee <cw9316.lee@...sung.com>

Checks information about tx_lanes, but is not used.

Since the commit below is applied, tx_lanes is deprecated.
 -[2/3] scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls from host
 -Message ID	20180904101719.18049-3-vivek.gautam@...eaurora.org

As a result, link_startup_notify->POST_CHANGE action does nothing.
No need to read tx_lanes.
If it is not going to be updated, it looks like it can be removed.

Signed-off-by: ChanWoo Lee <cw9316.lee@...sung.com>
---
 drivers/scsi/ufs/ufs-qcom.c | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index 9d9770f1db4f..124557525b5c 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
@@ -54,19 +54,6 @@ static void ufs_qcom_dump_regs_wrapper(struct ufs_hba *hba, int offset, int len,
 	ufshcd_dump_regs(hba, offset, len * 4, prefix);
 }
 
-static int ufs_qcom_get_connected_tx_lanes(struct ufs_hba *hba, u32 *tx_lanes)
-{
-	int err = 0;
-
-	err = ufshcd_dme_get(hba,
-			UIC_ARG_MIB(PA_CONNECTEDTXDATALANES), tx_lanes);
-	if (err)
-		dev_err(hba->dev, "%s: couldn't read PA_CONNECTEDTXDATALANES %d\n",
-				__func__, err);
-
-	return err;
-}
-
 static int ufs_qcom_host_clk_get(struct device *dev,
 		const char *name, struct clk **clk_out, bool optional)
 {
@@ -190,13 +177,6 @@ static int ufs_qcom_init_lane_clks(struct ufs_qcom_host *host)
 	return err;
 }
 
-static int ufs_qcom_link_startup_post_change(struct ufs_hba *hba)
-{
-	u32 tx_lanes;
-
-	return ufs_qcom_get_connected_tx_lanes(hba, &tx_lanes);
-}
-
 static int ufs_qcom_check_hibern8(struct ufs_hba *hba)
 {
 	int err;
@@ -566,9 +546,6 @@ static int ufs_qcom_link_startup_notify(struct ufs_hba *hba,
 		if (ufshcd_get_local_unipro_ver(hba) != UFS_UNIPRO_VER_1_41)
 			err = ufshcd_disable_host_tx_lcc(hba);
 
-		break;
-	case POST_CHANGE:
-		ufs_qcom_link_startup_post_change(hba);
 		break;
 	default:
 		break;
-- 
2.29.0