lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Sep 2021 08:11:25 +0200 From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org> To: Randy Dunlap <rdunlap@...radead.org> Cc: linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>, linux-media@...r.kernel.org, Andrzej Pietrasiewicz <andrzejtp2010@...il.com>, Jacek Anaszewski <jacek.anaszewski@...il.com>, Sylwester Nawrocki <s.nawrocki@...sung.com>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2] media: s5p-jpeg: rename JPEG marker constants to prevent build warnings Em Mon, 6 Sep 2021 21:40:22 -0700 Randy Dunlap <rdunlap@...radead.org> escreveu: > The use of a macro named 'RST' conflicts with one of the same name > in arch/mips/include/asm/mach-rc32434/rb.h. This causes build > warnings on some MIPS builds. > > Change the names of the JPEG marker constants to be in their own > namespace to fix these build warnings and to prevent other similar > problems in the future. > > Fixes these build warnings: > > In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c:14: > ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined > 43 | #define RST 0xd0 > | > ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition > 13 | #define RST (1 << 15) > > In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c:13: > ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined > 43 | #define RST 0xd0 > ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition > 13 | #define RST (1 << 15) > > In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c:12: > ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined > 43 | #define RST 0xd0 > ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition > 13 | #define RST (1 << 15) > > In file included from ../drivers/media/platform/s5p-jpeg/jpeg-core.c:31: > ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined > 43 | #define RST 0xd0 > ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition > 13 | #define RST (1 << 15) > > Also update the kernel-doc so that the word "marker" is not > repeated. > > Fixes: bb677f3ac434 ("[media] Exynos4 JPEG codec v4l2 driver") > Signed-off-by: Randy Dunlap <rdunlap@...radead.org> > Reported-by: kernel test robot <lkp@...el.com> > Cc: Mauro Carvalho Chehab <mchehab@...nel.org> > Cc: linux-media@...r.kernel.org > Cc: Andrzej Pietrasiewicz <andrzejtp2010@...il.com> > Cc: Jacek Anaszewski <jacek.anaszewski@...il.com> > Cc: Sylwester Nawrocki <s.nawrocki@...sung.com> > Cc: linux-arm-kernel@...ts.infradead.org > --- > v2: change all JPEG marker macros to be in their own namespace (as > suggested by Mauro) Applied, thanks! Regards, Mauro Thanks, Mauro
Powered by blists - more mailing lists