linux-kernel - Re: [PATCH 1/2] drivers: thermal: tsens: fix wrong check for tzd in irq handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YTfNx7WQ9QM9t3Z5@google.com>
Date:   Tue, 7 Sep 2021 13:38:31 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Thara Gopinath <thara.gopinath@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drivers: thermal: tsens: fix wrong check for tzd in
 irq handlers

On Sun, Sep 05, 2021 at 07:47:07PM +0200, Ansuel Smith wrote:
> Some device can have some thermal sensor disabled from the factory. The
> current 2 irq handler functions check all the sensor by default and the
> check if the sensor was actually registered is wrong. The tzd is
> actually never set if the registration fail hence the IS_ERR check is
> wrong.

Indeed, tsens_register() doesn't assign ->tzd when the registration of
the sensor fails.

> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>

Reviewed-by: Matthias Kaehlcke <mka@...omium.org>