linux-kernel - Re: [PATCH v2 0/3] namei: fix use-after-free and adjust calling conventions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r1e0rrfw.fsf@stepbren-lnx.us.oracle.com>
Date:   Tue, 07 Sep 2021 14:44:51 -0700
From:   Stephen Brennan <stephen.s.brennan@...cle.com>
To:     Alexander Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] namei: fix use-after-free and adjust calling
 conventions

Stephen Brennan <stephen.s.brennan@...cle.com> writes:
> Drawing from the comments on the last two patches from me and Dmitry,
> the concensus is that __filename_parentat() is inherently buggy, and
> should be removed. But there's some nice consistency to the way that
> the other functions (filename_create, filename_lookup) are named which
> would get broken.
>
> I looked at the callers of filename_create and filename_lookup. All are
> small functions which are trivial to modify to include a putname(). It
> seems to me that adding a few more lines to these functions is a good
> traedoff for better clarity on lifetimes (as it's uncommon for functions
> to drop references to their parameters) and better consistency.
>
> This small series combines the UAF fix from me, and the removal of
> __filename_parentat() from Dmitry as patch 1. Then I standardize
> filename_create() and filename_lookup() and their callers.
>
> v2: Fix double getname in user_path_create()
>
> Stephen Brennan (3):
>   namei: Fix use after free in kern_path_locked
>   namei: Standardize callers of filename_lookup()
>   namei: Standardize callers of filename_create()

Please ignore this! I missed some feedback from Al and will send a v3.

>
>  fs/fs_parser.c |   1 -
>  fs/namei.c     | 126 ++++++++++++++++++++++++++-----------------------
>  2 files changed, 66 insertions(+), 61 deletions(-)
>
> -- 
> 2.30.2