linux-kernel - Re: [PATCH] staging: r8188eu: remove unused function Hal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA=Fs0mg7ZjgK-NeeGehEVKczyfH2ZsruWe_nneroBJw6kz=zw@mail.gmail.com>
Date:   Tue, 7 Sep 2021 23:29:53 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Martin Kaiser <martin@...ser.cx>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: r8188eu: remove unused function Hal_ProSetCrystalCap()

On Tue, 7 Sept 2021 at 22:09, Michael Straube <straube.linux@...il.com> wrote:
>
> Remove unused function Hal_ProSetCrystalCap().
>
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>  drivers/staging/r8188eu/core/rtw_mp.c    | 9 ---------
>  drivers/staging/r8188eu/include/rtw_mp.h | 1 -
>  2 files changed, 10 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mp.c b/drivers/staging/r8188eu/core/rtw_mp.c
> index dabdd0406f30..82268f754da0 100644
> --- a/drivers/staging/r8188eu/core/rtw_mp.c
> +++ b/drivers/staging/r8188eu/core/rtw_mp.c
> @@ -924,12 +924,3 @@ void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv)
>  exit:
>         ;
>  }
> -
> -void Hal_ProSetCrystalCap(struct adapter *pAdapter, u32 CrystalCapVal)
> -{
> -       CrystalCapVal = CrystalCapVal & 0x3F;
> -
> -       // write 0x24[16:11] = 0x24[22:17] = CrystalCap
> -       PHY_SetBBReg(pAdapter, REG_AFE_XTAL_CTRL, 0x7FF800,
> -                    (CrystalCapVal | (CrystalCapVal << 6)));
> -}
> diff --git a/drivers/staging/r8188eu/include/rtw_mp.h b/drivers/staging/r8188eu/include/rtw_mp.h
> index b2befe09d944..73fb6974d076 100644
> --- a/drivers/staging/r8188eu/include/rtw_mp.h
> +++ b/drivers/staging/r8188eu/include/rtw_mp.h
> @@ -466,7 +466,6 @@ void Hal_TriggerRFThermalMeter(struct adapter *pAdapter);
>  u8 Hal_ReadRFThermalMeter(struct adapter *pAdapter);
>  void Hal_SetCCKContinuousTx(struct adapter *pAdapter, u8 bStart);
>  void Hal_SetOFDMContinuousTx(struct adapter *pAdapter, u8 bStart);
> -void Hal_ProSetCrystalCap (struct adapter *pAdapter , u32 CrystalCapVal);
>  void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv);
>  void MP_PHY_SetRFPathSwitch(struct adapter *pAdapter ,bool bMain);
>
> --
> 2.33.0
>

Looks good Michael, many thanks.

Acked-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil