linux-kernel - Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <755e99d3-4d72-3292-a5da-ad3d6045038e@codeaurora.org>
Date:   Wed, 8 Sep 2021 10:08:33 +0530
From:   Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
To:     Stephen Boyd <swboyd@...omium.org>, agross@...nel.org,
        alsa-devel@...a-project.org, bgoswami@...eaurora.org,
        bjorn.andersson@...aro.org, broonie@...nel.org,
        devicetree@...r.kernel.org, judyhsiao@...omium.org,
        lgirdwood@...il.com, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, perex@...ex.cz, plai@...eaurora.org,
        robh+dt@...nel.org, rohitkr@...eaurora.org,
        srinivas.kandagatla@...aro.org, tiwai@...e.com
Subject: Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital
 codecs

Thanks For Review Stephen!!!

On 9/8/2021 1:54 AM, Stephen Boyd wrote:
> Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)
>> Add header defining for lpass internal digital codecs rx,tx and va
>> dai node id's.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
>> ---
>>   include/dt-bindings/sound/qcom,lpass.h | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/include/dt-bindings/sound/qcom,lpass.h b/include/dt-bindings/sound/qcom,lpass.h
>> index 7b0b80b..187af45 100644
>> --- a/include/dt-bindings/sound/qcom,lpass.h
>> +++ b/include/dt-bindings/sound/qcom,lpass.h
>> @@ -10,6 +10,11 @@
>>
>>   #define LPASS_DP_RX    5
>>
>> +#define LPASS_CDC_DMA_RX0 6
>> +#define LPASS_CDC_DMA_TX3 7
>> +#define LPASS_CDC_DMA_VA0 8
>> +#define LPASS_MAX_PORTS 9
> Do we need LPASS_MAX_PORTS in the binding?
Yes.  based on this creating array of streams in machine driver. So to 
make upper limit introduced this macro.

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.