linux-kernel - Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Sep 2021 00:48:44 -0500
From:   Nishanth Menon <nm@...com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
CC:     Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        Bao Cheng Su <baocheng.su@...mens.com>,
        Chao Zeng <chao.zeng@...mens.com>
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering

On 07:25-20210908, Jan Kiszka wrote:
> On 08.09.21 04:44, Nishanth Menon wrote:
> > On 18:37-20210907, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@...mens.com>
> >>
> >> This ensures that the SD card will remain mmc0 across devices with and
> >> without eMMC.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> >> ---
> >>  arch/arm64/boot/dts/ti/k3-am65.dtsi | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> >> index a9fc1af03f27..785d931a2dd9 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
> >> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> >> @@ -31,6 +31,8 @@ aliases {
> >>  		i2c4 = &main_i2c2;
> >>  		i2c5 = &main_i2c3;
> >>  		ethernet0 = &cpsw_port1;
> >> +		mmc0 = &sdhci1;
> >> +		mmc1 = &sdhci0;
> > 
> > Jan,
> > 
> > Responding in context of [1]. Suggestion from Aswath is to do the
> > following instead at SoC level:
> > +		mmc0 = &sdhci0;
> > +		mmc1 = &sdhci1;
> > 
> 
> Then I will leave this up to you and will go back to v1 of this patch
> (as we require it the other way around).

Could you elaborate on the rationale as to why the other way around?
That would probably provide the reasoning to override the SoC generic
definitions in the board dts/dtsi as the exception case.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D