linux-kernel - Re: [PATCH 1/2] soc: amlogic: canvas: Make use of the helper function devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Sep 2021 09:47:50 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] soc: amlogic: canvas: Make use of the helper function
 devm_platform_ioremap_resource()

On 08/09/2021 09:15, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>  drivers/soc/amlogic/meson-canvas.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/amlogic/meson-canvas.c b/drivers/soc/amlogic/meson-canvas.c
> index d0329ad170d1..383b0cfc584e 100644
> --- a/drivers/soc/amlogic/meson-canvas.c
> +++ b/drivers/soc/amlogic/meson-canvas.c
> @@ -168,7 +168,6 @@ EXPORT_SYMBOL_GPL(meson_canvas_free);
>  
>  static int meson_canvas_probe(struct platform_device *pdev)
>  {
> -	struct resource *res;
>  	struct meson_canvas *canvas;
>  	struct device *dev = &pdev->dev;
>  
> @@ -176,8 +175,7 @@ static int meson_canvas_probe(struct platform_device *pdev)
>  	if (!canvas)
>  		return -ENOMEM;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	canvas->reg_base = devm_ioremap_resource(dev, res);
> +	canvas->reg_base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(canvas->reg_base))
>  		return PTR_ERR(canvas->reg_base);
>  
> 

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>