[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210907214047.04ef5ac8@rorschach.local.home>
Date: Tue, 7 Sep 2021 21:40:47 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Carles Pey <carles.pey@...il.com>
Cc: Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ftrace: add unit test for removing trace function
On Sat, 4 Sep 2021 22:02:48 +0400
Carles Pey <carles.pey@...il.com> wrote:
Two errors here.
-ENOCHANGELOG
-ENOSIG
No matter how trivial the patch, you need a change log. The subject is
"what" the patch does, the change log is "why" it is done. What was the
motivation for this patch.
And more critical, I can't even take this patch because there's no
"Signed-off-by".
-- Steve
> ---
> kernel/trace/trace_selftest.c | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
> index adf7ef194005..875b4f1a0476 100644
> --- a/kernel/trace/trace_selftest.c
> +++ b/kernel/trace/trace_selftest.c
> @@ -287,6 +287,40 @@ static int trace_selftest_ops(struct trace_array *tr, int cnt)
> if (trace_selftest_test_probe3_cnt != 4)
> goto out_free;
>
> + /* Remove trace function from probe 3 */
> + func1_name = "!" __stringify(DYN_FTRACE_TEST_NAME);
> + len1 = strlen(func1_name);
> +
> + ftrace_set_filter(&test_probe3, func1_name, len1, 0);
> +
> + DYN_FTRACE_TEST_NAME();
> +
> + print_counts();
> +
> + if (trace_selftest_test_probe1_cnt != 3)
> + goto out_free;
> + if (trace_selftest_test_probe2_cnt != 2)
> + goto out_free;
> + if (trace_selftest_test_probe3_cnt != 4)
> + goto out_free;
> + if (cnt > 1) {
> + if (trace_selftest_test_global_cnt == 0)
> + goto out_free;
> + }
> + if (trace_selftest_test_dyn_cnt == 0)
> + goto out_free;
> +
> + DYN_FTRACE_TEST_NAME2();
> +
> + print_counts();
> +
> + if (trace_selftest_test_probe1_cnt != 3)
> + goto out_free;
> + if (trace_selftest_test_probe2_cnt != 3)
> + goto out_free;
> + if (trace_selftest_test_probe3_cnt != 5)
> + goto out_free;
> +
> ret = 0;
> out_free:
> unregister_ftrace_function(dyn_ops);
Powered by blists - more mailing lists